Open
Conversation
…pgrade_to_volto16
pnicolli
previously approved these changes
Dec 11, 2023
pnicolli
reviewed
Dec 11, 2023
| "dependencies": { | ||
| "@hcaptcha/react-hcaptcha": "^0.3.6", | ||
| "file-saver": "^2.0.5", | ||
| "react-dates": "21.8.0", |
Member
There was a problem hiding this comment.
Was it broken without this?
If this is needed, I am fine with adding it (maybe together with rc-time-picker), but I would add the same specific version we have in core volto to avoid issues with bundle size and maybe also discrepancies.
Member
Author
There was a problem hiding this comment.
@pnicolli I don't remember, to be honest, but yes, we should add the version from Volto Core 😉
Member
Author
There was a problem hiding this comment.
@pnicolli Hmm, checking the commits log, I can see @ionlizarazu added it https://github.com/collective/volto-form-block/pull/67/commits.
Thus, for sure there were some issues there 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.