Skip to content

Conversation

@ale-rt
Copy link
Member

@ale-rt ale-rt commented Nov 19, 2025

This removes the tests for Plone/Python versions that are obsolete and for which running the tests on GHA would require too much magic.

This removes the tests for Plone/Python versions that are obsolete
and for which running the tests on GHA would require too much magic.
@ale-rt ale-rt requested a review from davisagli November 19, 2025 10:55
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  • increase the major version
  • make sure there is a changelog saying we are dropping support for Plone 5.1 and Python < 3.8
  • update the trove classifiers in setup.py

@davisagli
Copy link
Member

Oh, this is an older branch, so increasing the major version doesn't make sense. But let's do the others.

@ale-rt
Copy link
Member Author

ale-rt commented Nov 20, 2025

The 3.x branch (current master) can still support 5.1/Python 2.7 and I am using it with Plone 6.1/Python 3.13.
The test action is failing now on master.
This PR just tries to fix the CI for what is possible .
I would anyway not touch anything here and focus on the master branch that will start targeting Plone 6.0+ after #57

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@ale-rt ale-rt merged commit 570363f into 3.x Nov 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants