-
Notifications
You must be signed in to change notification settings - Fork 7
add pat-select2 portlet #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1letter
commented
Oct 6, 2025
- add new portlet option -> select2
- update translations
|
Note: the release checks can be fixed with upgrading to latest
|
petschki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this branch and it looks promising! 🥳
One thought though:
If I have a single select dropdown I would have expected the searchable dropdown (like we have as the language selector in the edit mask) rather than a input field with a single tag:
Besides that, the tile integration is missing also (https://github.com/collective/collective.collectionfilter/blob/main/src/collective/collectionfilter/tiles/filter.pt) we're using filter tiles in mosaic extensively ... it would be great to have it there too 😉
add pat-select2 for mosaic filter tile fix empty result set
|
@petschki |
| <select class="form-select" | ||
| name="${view/filter_id}" | ||
| tal:attributes=" | ||
| class python:'form-select pat-select2' if view.input_type=='select2_single' else 'form-select'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not combine form-select with pat-select2 css class ... either one of them is enough ... otherwise you end up with duplicated dropdown markers:
| class python:'form-select pat-select2' if view.input_type=='select2_single' else 'form-select'; | |
| class python:'pat-select2' if view.input_type=='select2_single' else 'form-select'; |
| <select class="form-select" | ||
| name="${view/filter_id}" | ||
| tal:attributes=" | ||
| class python:'form-select pat-select2' if view.input_type=='select2_single' else 'form-select'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... same here.
| class python:'form-select pat-select2' if view.input_type=='select2_single' else 'form-select'; | |
| class python:'pat-select2' if view.input_type=='select2_single' else 'form-select'; |
petschki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my point of view, this is good to merge. Failing testsetup could need some love though ...