Skip to content

Conversation

@kazssym
Copy link
Contributor

@kazssym kazssym commented Dec 25, 2024

Adjust macro definitions to prevent conflicts with Microsoft Win32 API headers by using push and pop macro directives.

Fixes #468

@kazssym
Copy link
Contributor Author

kazssym commented Dec 25, 2024

This PR changes the SODEBUGERROR_STORE_ERROR_DEF macro's usage as the marker to pop the definition of ERROR. Due to the language spec, it could not be used to restore the original definition at all.

@VolkerEnderlein VolkerEnderlein merged commit b1a082c into coin3d:master Jan 19, 2025
5 checks passed
@VolkerEnderlein
Copy link
Member

Thanks for reworking the prvious PR. Your contribution to Coin development is highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<Inventor/errors/SoDebugErrors.h> leaves macro ERROR defined to an undeclared symbol

2 participants