Fix the syntax rule (regex) for creating a new instance with a new keyword bug mentioned in issue #116

[guyleaf]

Modification

1. Fix the syntax rule (regex) for creating a new instance with a new keyword
2. Add some tests for testing the syntax rule with the prefix "new"

Detail

I changed ^new(?>\s*)

protected static readonly Regex instanceCreationWithNewKeywordRegex = new Regex(@"^new(?>\s*)((?<isAnonymous>[{{])|((?<name>[\p{L}_][\p{L}_0-9\.]*)(?>\s*)(?<isgeneric>[<](?>[^<>]+|(?<gentag>[<])|(?<-gentag>[>]))*(?(gentag)(?!))[>])?(?>\s*)((?<isfunction>[(])|(?<isArray>\[)|(?<isInit>[{{]))?))", RegexOptions.IgnoreCase | RegexOptions.Compiled);

to ^new(?>\s+)

protected static readonly Regex instanceCreationWithNewKeywordRegex = new Regex(@"^new(?>\s+)((?<isAnonymous>[{{])|((?<name>[\p{L}_][\p{L}_0-9\.]*)(?>\s*)(?<isgeneric>[<](?>[^<>]+|(?<gentag>[<])|(?<-gentag>[>]))*(?(gentag)(?!))[>])?(?>\s*)((?<isfunction>[(])|(?<isArray>\[)|(?<isInit>[{{]))?))", RegexOptions.IgnoreCase | RegexOptions.Compiled);

Reason

The original regex rule will detect 3 cases.

1. new instance: new List() ✔
2. new function: new(...) ✔
3. newCards (variable name) (❌ false detection

The original one should not detect the last one.

[guyleaf]

The problem is mentioned in #116

[guyleaf]

Still fixing regex...
I find this modification should affect other tests error, like new(...), but it is still working.
Because the space after the new keyword is at least one space.

(Update) I figure out why it works.
"(?>.." is to capture keywords.
So, if we keep the original one, it will detect words with the prefix "new" without blanks. (because it is \s*)
And with \s+, new() is still working because there is a ?<isfunction> regex after that.

[codingseb]

I changed ^new(?>\s*)
to ^new(?>\s+)

Of course it is obvious. My bad.
Thanks a lot for the bug report and for your PR @guyleaf .
I have less time these days for ExpressionEvaluator so your help is greatly appreciate.

I will also try to correct quickly #115 and publish a new version asap.