Skip to content

Add test for *.txt include pattern filtering #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add test for *.txt include pattern filtering #116

merged 1 commit into from
Jan 9, 2025

Conversation

RyanL2004
Copy link
Contributor

Description

Added test case for verifying file pattern matching with *.txt include pattern.

Changes Made

  • Added test_include_txt_pattern to verify that:
    • Only .txt files are included when using *.txt pattern
    • Python (.py) files are correctly excluded
    • All expected .txt files are found in the correct locations

Related Issue

Addresses TODO comment in test_query_ingestion.py for testing include patterns.

Testing

  • Test has been run locally and passes
  • No modifications to existing code, only adds new test coverage

cyclotruc
cyclotruc approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@cyclotruc cyclotruc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that sight of a #TODO being replaced by code
Thank you!

@cyclotruc cyclotruc merged commit aa470aa into coderamp-labs:main Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyclotruc cyclotruc cyclotruc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanL2004 @cyclotruc