Skip to content

Less strict about message type of JSON payloads #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2020
Merged

Less strict about message type of JSON payloads #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions wsjson/wsjson.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,11 @@ func Read(ctx context.Context, c *websocket.Conn, v interface{}) error {
func read(ctx context.Context, c *websocket.Conn, v interface{}) (err error) {
defer errd.Wrap(&err, "failed to read JSON message")

typ, r, err := c.Reader(ctx)
_, r, err := c.Reader(ctx)
if err != nil {
return err
}

if typ != websocket.MessageText {
c.Close(websocket.StatusUnsupportedData, "expected text message")
return fmt.Errorf("expected text message for JSON but got: %v", typ)
}

b := bpool.Get()
defer bpool.Put(b)

Expand Down