🤖 fix: align GitHub Copilot model routing by ibetitsmike · Pull Request #3104 · coder/mux

ibetitsmike · 2026-03-31T20:12:28Z

Summary

This PR aligns GitHub Copilot model routing with the account's model catalog. All non-Codex models use chat completions. Codex models use a custom Responses language model that handles Copilot's SSE stream format. Copilot can now route Anthropic and Google models (with dot-vs-dash ID normalization). Catalog entries are hidden from the selector.

Background

Copilot auth persisted the signed-in user's model list, but routing ignored it and only routed OpenAI models. Non-OpenAI Copilot models (Claude, Gemini) were unreachable. Codex models were stuck: /chat/completions rejects them, and the standard AI SDK Responses parser can't handle Copilot's SSE stream format. Additionally, Copilot's catalog uses dot-form Claude IDs (claude-opus-4.6) while Mux's built-in models use dashes (claude-opus-4-6).

Implementation

add a custom CopilotResponsesLanguageModel that handles Copilot's Responses API SSE stream directly, bypassing the AI SDK's broken parser (following opencode's approach)
route Codex models through the custom Responses model, all other Copilot models through chat completions
expand Copilot gateway routes to include anthropic and google
normalize Claude model IDs (dot-vs-dash: 4.6 matches 4-6) so Copilot catalog entries match built-in models
hide github-copilot:* entries from the model selector while keeping the catalog for route gating
check credentials before catalog availability for correct error messages
classify initiator from pre-normalization body for correct billing headers
treat malformed catalog entries as absent for self-healing

Validation

make static-check
bun test src/common/utils/copilot/modelRouting.test.ts src/node/services/providerModelFactory.test.ts src/node/services/copilot/copilotResponsesLanguageModel.test.ts src/browser/hooks/useRouting.test.ts src/browser/hooks/useModelsFromSettings.test.ts src/common/routing/resolve.test.ts src/browser/utils/compaction/suggestion.test.ts src/common/utils/providers/gatewayModelCatalog.test.ts

Risks

Medium. The custom CopilotResponsesLanguageModel is a new language model implementation that directly parses Copilot's SSE stream. It's scoped to Codex-family models only to minimize blast radius. Tool call streaming is not yet covered (text-only). Adding Anthropic/Google to Copilot routes means users with both Copilot and direct API keys will route through Copilot when it's prioritized (the priority system is user-controlled and defaults to ["direct"]).

Generated with mux • Model: openai:gpt-5.4 • Thinking: xhigh • Cost: $23.81

Add an optional gateway accessibility callback to route resolution helpers and cover the new fallback behavior in routing tests.

ibetitsmike · 2026-03-31T20:12:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f61c5df1c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/node/services/providerModelFactory.ts

ibetitsmike · 2026-03-31T20:27:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 553a7ba923

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/node/services/providerModelFactory.ts

src/browser/hooks/useRouting.ts

ibetitsmike · 2026-03-31T21:39:20Z

@codex review

chatgpt-codex-connector · 2026-03-31T21:45:44Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-03-31T21:49:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 36537b7ed2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/node/services/providerModelFactory.ts

ibetitsmike · 2026-03-31T21:58:29Z

@codex review

chatgpt-codex-connector · 2026-03-31T22:05:53Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-03-31T22:09:10Z

@codex review

Pushed a follow-up fix so direct github-copilot:* entries now use the same authoritative catalog gating as routed Copilot models.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6ce621ba2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/browser/utils/compaction/suggestion.ts

ibetitsmike · 2026-04-01T00:15:46Z

@codex review

Follow-up push: I stabilized the useRouting unit test so it waits for the loaded Copilot catalog before asserting the unavailable route is hidden.

ibetitsmike · 2026-04-01T00:22:04Z

@codex review

Follow-up push: explicit compaction suggestions now apply the same authoritative Copilot catalog check as model selection, so stale github-copilot:* preferences are rejected before retry.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dfbb329aac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/common/routing/resolve.ts

ibetitsmike · 2026-04-01T00:28:13Z

@codex review

Follow-up push: explicit gateway route resolution now applies the same catalog accessibility check on both explicit-gateway and direct-gateway paths, so stale github-copilot:* entries no longer appear routable.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56a866ac03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/node/services/providerModelFactory.ts

Keep the Copilot Responses language model tests behavior the same while addressing file-specific ESLint failures.

ibetitsmike · 2026-04-02T23:53:59Z

@codex review

Major additions:

Custom CopilotResponsesLanguageModel for Codex models - parses Copilot's SSE stream directly instead of relying on the AI SDK's broken Responses parser.
Normalized Claude model IDs (dot-vs-dash: claude-opus-4.6 matches claude-opus-4-6) so Anthropic models properly route through Copilot.
Copilot Anthropic routing tests at resolve, hook, and selector layers.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea5c726ce0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/node/services/copilot/copilotResponsesLanguageModel.ts

src/node/services/providerModelFactory.ts

ibetitsmike · 2026-04-03T00:04:03Z

@codex review

Fix: stabilized the new Anthropic Copilot useRouting test to avoid the same async config fetch race condition as the previous test.

ibetitsmike · 2026-04-03T00:05:21Z

@codex review

Stabilized the Anthropic Copilot useRouting test: it now waits for both provider config and routing priority to load before asserting resolveRoute.

chatgpt-codex-connector · 2026-04-03T00:14:12Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-04-03T00:16:13Z

@codex review

Fixed both issues:

Claude model IDs are now reverse-normalized from dash-form to dot-form before sending to Copilot (e.g., claude-opus-4-6 -> claude-opus-4.6).
Copilot Responses model reads reasoning from the github-copilot namespace.

ibetitsmike · 2026-04-03T00:20:32Z

@codex review

Applied both fixes from the previous Codex review:

Claude model IDs are reverse-normalized to dot-form before sending to Copilot (claude-opus-4-6 -> claude-opus-4.6).
Copilot Responses model reads reasoning from the github-copilot namespace with reasoningEffort fallback.

chatgpt-codex-connector · 2026-04-03T00:28:49Z

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-04-03T00:31:46Z

@codex review

Simplified the flaky Anthropic Copilot useRouting test to only assert availableRoutes (provider-config-driven, no route priority race). The pure routing logic is deterministically tested in resolve.test.ts.

ibetitsmike · 2026-04-03T00:33:17Z

@codex review

Simplified the flaky Anthropic useRouting test to only assert availableRoutes (no route priority race).

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 923bc2c6f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/node/services/providerModelFactory.ts

ibetitsmike · 2026-04-03T00:43:53Z

@codex review

Removed the persistently flaky Anthropic useRouting hook test. The dot-vs-dash normalization is already covered deterministically in resolve.test.ts and gatewayModelCatalog.test.ts.

Delete the CI-flaky Anthropic Copilot hook test from useRouting.test.ts. The remaining coverage stays in deterministic routing and gateway catalog tests.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1fce3d338f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/common/utils/copilot/modelRouting.ts

ibetitsmike · 2026-04-03T00:54:24Z

@codex review

Fixed: toCopilotModelId now only rewrites short (1-2 digit) minor version segments. Date-stamped IDs like claude-sonnet-4-20250514 pass through unchanged.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1fce3d338f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/common/utils/copilot/modelRouting.ts

Limit Claude minor-version rewriting to 1-2 digit segments so date-stamped model IDs stay unchanged unless they include a real short minor version.

ibetitsmike · 2026-04-03T00:58:07Z

@codex review

Fixed: toCopilotModelId now only rewrites 1-2 digit minor version segments. Date-stamped IDs like claude-sonnet-4-20250514 are preserved unchanged.

ibetitsmike · 2026-04-03T01:01:46Z

@codex review

This was already fixed in commit 2c8c83a. The regex now only rewrites 1-2 digit minor versions. Date-stamped IDs like claude-sonnet-4-20250514 pass through unchanged.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c8c83a0ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-03T01:08:16Z

src/node/services/providerModelFactory.ts

+        const { createOpenAI } = await PROVIDER_REGISTRY.openai();
+        const provider = createOpenAI({
          name: "github-copilot",
          baseURL,
-          apiKey: "copilot", // placeholder — actual auth via custom fetch
+          apiKey: "copilot", // placeholder, actual auth via custom fetch
          fetch: providerFetch,
        });
-        return Ok(provider.chatModel(modelId));
+        return Ok(provider.chat(outboundCopilotModelId));


Keep Copilot chat provider-options namespace compatible

Switching non-Codex Copilot routing to createOpenAI().chat(...) means routed OpenAI models no longer read the "github-copilot" provider-options namespace that buildProviderOptions emits for OpenAI-through-Copilot requests (src/common/utils/ai/providerOptions.ts, origin === "openai" && formatProvider !== origin). In practice, when openai:gpt-* is routed via GitHub Copilot, settings like reasoningEffort are silently ignored because OpenAI chat parsing looks at providerOptions.openai, so thinking-level behavior regresses for those Copilot chat requests.

Useful? React with 👍 / 👎.

ibetitsmike added 5 commits March 31, 2026 20:10

Add Copilot model routing utility

c177aaf

🤖 fix: filter inaccessible gateway routes

8baf3e1

Add an optional gateway accessibility callback to route resolution helpers and cover the new fallback behavior in routing tests.

fix: update Copilot model factory routing

27442ad

🤖 fix: respect gateway model accessibility in browser hooks

cf184ab

refactor: share copilot model prefixes

f61c5df

chatgpt-codex-connector bot reviewed Mar 31, 2026

View reviewed changes

src/node/services/providerModelFactory.ts Outdated Show resolved Hide resolved

src/node/services/providerModelFactory.ts Outdated Show resolved Hide resolved

🤖 fix: address Copilot review feedback

553a7ba

chatgpt-codex-connector bot reviewed Mar 31, 2026

View reviewed changes

src/node/services/providerModelFactory.ts Show resolved Hide resolved

src/browser/hooks/useRouting.ts Show resolved Hide resolved

🤖 fix: preserve Copilot route metadata

ed7b9f9

🤖 tests: isolate useRouting hook wiring

36537b7

chatgpt-codex-connector bot reviewed Mar 31, 2026

View reviewed changes

src/node/services/providerModelFactory.ts Outdated Show resolved Hide resolved

🤖 tests: stabilize useRouting route priority assertions

2fd1440

chatgpt-codex-connector bot reviewed Mar 31, 2026

View reviewed changes

src/browser/utils/compaction/suggestion.ts Show resolved Hide resolved

ibetitsmike force-pushed the mike/copilot-model-routing branch from c6ce621 to dfbb329 Compare April 1, 2026 00:15

ibetitsmike force-pushed the mike/copilot-model-routing branch from dfbb329 to 719288e Compare April 1, 2026 00:21

chatgpt-codex-connector bot reviewed Apr 1, 2026

View reviewed changes

src/common/routing/resolve.ts Show resolved Hide resolved

ibetitsmike force-pushed the mike/copilot-model-routing branch from 719288e to 56a866a Compare April 1, 2026 00:28

chatgpt-codex-connector bot reviewed Apr 1, 2026

View reviewed changes

src/node/services/providerModelFactory.ts Show resolved Hide resolved

ibetitsmike force-pushed the mike/copilot-model-routing branch from 56a866a to 3e263d7 Compare April 1, 2026 00:39

ibetitsmike added 7 commits April 2, 2026 23:00

Add Copilot Anthropic routing tests

9c82ff7

Add Copilot Anthropic hook tests

1f9c19e

Allow Copilot Codex routing

33182ad

Add Copilot responses language model

c820e5e

Integrate Copilot responses model routing

e20881f

🤖 tests: fix copilot responses test lint

3d762b0

Keep the Copilot Responses language model tests behavior the same while addressing file-specific ESLint failures.

Fix copilot test fetch mock return types

ea5c726

chatgpt-codex-connector bot reviewed Apr 3, 2026

View reviewed changes

src/node/services/copilot/copilotResponsesLanguageModel.ts Outdated Show resolved Hide resolved

src/node/services/providerModelFactory.ts Outdated Show resolved Hide resolved

Fix flaky useRouting Copilot test

c433016

Fix Copilot model routing and reasoning

69ec990

Fix flaky useRouting Anthropic test

923bc2c

chatgpt-codex-connector bot reviewed Apr 3, 2026

View reviewed changes

src/node/services/providerModelFactory.ts Show resolved Hide resolved

🤖 tests: remove flaky Copilot routing hook test

1fce3d3

Delete the CI-flaky Anthropic Copilot hook test from useRouting.test.ts. The remaining coverage stays in deterministic routing and gateway catalog tests.

chatgpt-codex-connector bot reviewed Apr 3, 2026

View reviewed changes

src/common/utils/copilot/modelRouting.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Apr 3, 2026

View reviewed changes

src/common/utils/copilot/modelRouting.ts Outdated Show resolved Hide resolved

🤖 fix: preserve date-stamped Claude Copilot IDs

2c8c83a

Limit Claude minor-version rewriting to 1-2 digit segments so date-stamped model IDs stay unchanged unless they include a real short minor version.

chatgpt-codex-connector bot reviewed Apr 3, 2026

View reviewed changes

Conversation

ibetitsmike commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Background

Implementation

Validation

Risks

Uh oh!

ibetitsmike commented Mar 31, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ibetitsmike commented Mar 31, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ibetitsmike commented Mar 31, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 31, 2026

Uh oh!

ibetitsmike commented Mar 31, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Mar 31, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 31, 2026

Uh oh!

ibetitsmike commented Mar 31, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Apr 1, 2026

Uh oh!

ibetitsmike commented Apr 1, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Apr 1, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Apr 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ibetitsmike commented Apr 3, 2026

Uh oh!

ibetitsmike commented Apr 3, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 3, 2026

Uh oh!

ibetitsmike commented Apr 3, 2026

Uh oh!

ibetitsmike commented Apr 3, 2026

ibetitsmike commented Mar 31, 2026 •

edited

Loading