Skip to content

feat: shield:setup does Email setup #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 7, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 3, 2023

Needs #871

Description

  • shield:setup does Email setup
  • refactor

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the enhancement New feature or request label Oct 3, 2023
@kenjis kenjis marked this pull request as draft October 3, 2023 05:17
@kenjis kenjis force-pushed the feat-setup-command-email-setup branch 2 times, most recently from b7b0321 to 9ae74a0 Compare October 3, 2023 20:21
@datamweb datamweb marked this pull request as ready for review October 3, 2023 20:27
@datamweb datamweb added the stale Pull requests with conflicts label Oct 3, 2023
@datamweb datamweb marked this pull request as draft October 3, 2023 20:27
@kenjis kenjis force-pushed the feat-setup-command-email-setup branch from 9ae74a0 to a7ad37e Compare October 3, 2023 20:35
@kenjis kenjis marked this pull request as ready for review October 3, 2023 20:40
@kenjis kenjis removed the stale Pull requests with conflicts label Oct 3, 2023
@datamweb
Copy link
Collaborator

datamweb commented Oct 3, 2023

Just note, resulte tests in windows:

There were 4 failures:

1) Tests\Commands\UserTest::testList
Failed asserting that 'Id       User\r\n
1       user8 ([email protected])\r\n
2       user9 ([email protected])\r\n
' contains "Id  User
1       user8 ([email protected])
2       user9 ([email protected])
".

P:\MyGitHubWork\shield\tests\Commands\UserTest.php:464

2) Tests\Commands\UserTest::testListByEmail
Failed asserting that 'Id       User\r\n
2       user9 ([email protected])\r\n
' contains "Id  User
2       user9 ([email protected])
".

P:\MyGitHubWork\shield\tests\Commands\UserTest.php:490

3) Tests\Commands\SetupTest::testRunEmailConfigIsFine
Failed asserting that '  Created: vfs://root/Config/Auth.php\r\n
  Created: vfs://root/Config/AuthGroups.php\r\n
  Created: vfs://root/Config/AuthToken.php\r\n
  Updated: vfs://root/Controllers/BaseController.php\r\n
  Updated: vfs://root/Config/Routes.php\r\n
  Updated: We have updated file 'vfs://root/Config/Security.php' for security reasons.\r\n
  Email Setup: Everything is fine.\r\n
Running all new migrations...\r\n
Migrations complete.\r\n
\r\n
' contains "  Created: vfs://root/Config/Auth.php
  Created: vfs://root/Config/AuthGroups.php
  Created: vfs://root/Config/AuthToken.php
  Updated: vfs://root/Controllers/BaseController.php
  Updated: vfs://root/Config/Routes.php
  Updated: We have updated file 'vfs://root/Config/Security.php' for security reasons.".

P:\MyGitHubWork\shield\tests\Commands\SetupTest.php:111

4) Tests\Commands\SetupTest::testRun
Failed asserting that '  Created: vfs://root/Config/Auth.php\r\n
  Created: vfs://root/Config/AuthGroups.php\r\n
  Created: vfs://root/Config/AuthToken.php\r\n
  Updated: vfs://root/Controllers/BaseController.php\r\n
  Updated: vfs://root/Config/Routes.php\r\n
  Updated: We have updated file 'vfs://root/Config/Security.php' for security reasons.\r\n
  Updated: vfs://root/Config/Email.php\r\n
Running all new migrations...\r\n
Migrations complete.\r\n
\r\n
' contains "  Created: vfs://root/Config/Auth.php
  Created: vfs://root/Config/AuthGroups.php
  Created: vfs://root/Config/AuthToken.php
  Updated: vfs://root/Controllers/BaseController.php
  Updated: vfs://root/Config/Routes.php
  Updated: We have updated file 'vfs://root/Config/Security.php' for security reasons.
  Updated: vfs://root/Config/Email.php".

P:\MyGitHubWork\shield\tests\Commands\SetupTest.php:76

FAILURES!
Tests: 466, Assertions: 1029, Failures: 4.

Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!

@kenjis kenjis merged commit 112ba2a into codeigniter4:develop Oct 7, 2023
@kenjis kenjis deleted the feat-setup-command-email-setup branch October 7, 2023 22:43
@kenjis
Copy link
Member Author

kenjis commented Oct 7, 2023

@datamweb Thank you for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants