-
Notifications
You must be signed in to change notification settings - Fork 139
feat: add shield:model
command
#558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shield:model
command
#558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming it MyUserModel means that factories won't pick it up automatically when searching for UserModel. This seems a loss to me, maybe not for the library itself but for any supporting code.
|
Oh, I get an error if I specify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tried with UserModel as the generated filename, I think the only issue was the class name conflict. I've made suggestions here to fix that in the code (though not the docs).
I think this will fix @MGatner concerns, which I agree with.
Other than that, my only suggestion might be to provide a default classname at the cli prompt.
ffcce42
to
718dd4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't run this but the code looks good. Thanks for making that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for taking this one over.
@kenjis waiting for you. Did your worries go away? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all.
Supersedes and closes #491