-
Notifications
You must be signed in to change notification settings - Fork 138
feat: add filter permission and group #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add filter permission and group #393
Conversation
If you are not familiar with PHPUnit testing, See Resources |
No problem. If someone really wants this feature, they would take over this PR. |
How does one take over or contribute to an existing PR? Please advise. |
Get this PR branch into your local repository, and push it to your GitHub repository. If you have
You can get this |
Or with just Git: git remote add jlopes90 https://github.com/jlopes90/shield.git
git fetch jlopes90 You can then make a new branch starting from the existing one: git switch -c my-takeover jlopes90/add-filter-permission-and-group (I'm mobile so please excuse me if I didn't get something quiet right) |
In fact, I always wondered how @kenjis could handle PR created by others. P:\MyGitHubWork\shield>git fetch jlopes90
fatal: unable to access 'https://github.com/jlopes90/shield.git/': OpenSSL SSL_connect: Connection was reset in connection to github.com:443 After a bit of research I found that setting SSH Key can fix the problem.
I like this method, because other people's commits are not removed, and their contributions are recorded in the source. It is beautiful and fair. P:\MyGitHubWork\shield>git fetch jlopes90
Enter passphrase for key '/c/Users/ppars/.ssh/id_ed50212':
remote: Enumerating objects: 68, done.
remote: Counting objects: 100% (37/37), done.
remote: Total 68 (delta 37), reused 37 (delta 37), pack-reused 31
Unpacking objects: 100% (68/68), 9.05 KiB | 52.00 KiB/s, done.
From github.com:jlopes90/shield
* [new branch] add-filter-permission-and-group -> jlopes90/add-filter-permission-and-group
* [new branch] develop -> jlopes90/develop
* [new branch] docs -> jlopes90/docs
* [new branch] magic-link-add-link-back-to-login -> jlopes90/magic-link-add-link-back-to-login
* [new branch] master -> jlopes90/master P:\MyGitHubWork\shield>git switch -c my-takeover jlopes90/add-filter-permission-and-group
Switched to a new branch 'my-takeover'
branch 'my-takeover' set up to track 'jlopes90/add-filter-permission-and-group'.
P:\MyGitHubWork\shield>git status
On branch my-takeover
Your branch is up to date with 'jlopes90/add-filter-permission-and-group'.
nothing to commit, working tree clean |
Yay! Glad it was helpful. Working across remotes and preserving or co-authoring work is complicated but important, and once you do it a few times it starts to feel natural. |
This feature seems to be needed by many, so please feel free to send new PRs based on this PR if anyone can. |
I don't think anyone has claimed it. |
Comment 5: I think it has caused the audience to misunderstand. So anyone can continue if they want. |
Ok. I'll take this one over. It's a great start and a much needed feature. |
Superseded by #535 |
Supersedes #270