Skip to content

fix: code style #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2025
Merged

fix: code style #1269

merged 2 commits into from
Jul 5, 2025

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Jul 5, 2025

Description
This PR fixes the code style, see: https://github.com/codeigniter4/shield/actions/runs/16089549638/job/45404784411

Rather a cosmetic thing.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like what I did in the main repo, you can change @phpstan-param to native @param since IDEs can now understand literal strings and array shapes in PHPDocs. And that will retain the original phpdoc order.

@michalsn
Copy link
Member Author

michalsn commented Jul 5, 2025

Oh, thanks! I was on autopilot here 😅

@michalsn michalsn merged commit 94cc0ce into codeigniter4:develop Jul 5, 2025
34 checks passed
@michalsn
Copy link
Member Author

michalsn commented Jul 5, 2025

Thanks @paulbalandan

@michalsn michalsn deleted the fix/cs branch July 5, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants