Skip to content

test: restore TimeTest::testUnserializeTimeObject() #7785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2023
Merged

test: restore TimeTest::testUnserializeTimeObject() #7785

merged 1 commit into from
Aug 6, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 6, 2023 •
edited
Loading

Description
Closes #7362
See #7362 (comment)

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Aug 6, 2023
@kenjis kenjis changed the title test: restore testUnserializeTimeObject() test: restore TimeTest::testUnserializeTimeObject() Aug 6, 2023
@kenjis
Copy link
Member Author

kenjis commented Aug 6, 2023

Okay, tests on PHP 8.2 passed.

@kenjis kenjis merged commit 46a1e5e into codeigniter4:develop Aug 6, 2023
@kenjis kenjis deleted the test-restore-Time-serialize-tests branch August 6, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev: [Time] PHP 8.2.4 SIGSEGV
2 participants
@kenjis @paulbalandan