Skip to content

style: Use all available checked tokens for no_extra_blank_lines #7729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paulbalandan
Copy link
Member

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Jul 24, 2023

Generally in favor, a couple opinions. Please remember to include final changes in DevKit. I need to do a release over there soon...

@paulbalandan paulbalandan force-pushed the no-extra-blank-lines branch 2 times, most recently from 56e70b2 to 7631e18 Compare July 26, 2023 10:30
@paulbalandan paulbalandan force-pushed the no-extra-blank-lines branch from 7631e18 to e71383b Compare July 27, 2023 02:58
@paulbalandan paulbalandan force-pushed the no-extra-blank-lines branch from e71383b to 9f8bc2f Compare July 27, 2023 03:27
@paulbalandan paulbalandan merged commit 6cd1a91 into codeigniter4:develop Jul 27, 2023
@paulbalandan paulbalandan deleted the no-extra-blank-lines branch July 27, 2023 09:04
@kenjis kenjis mentioned this pull request Jul 28, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants