Fix failing tests in Windows for RoutesTest and NamespacesTest #7719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kenjis merged 2 commits into codeigniter4:develop from paulbalandan:failing-tests

Jul 25, 2023

Member

paulbalandan commented Jul 19, 2023

Description
Fixes the line ending and directory separators identified for those 2 tests in #7491

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis reviewed

View reviewed changes

tests/system/Commands/Utilities/NamespacesTest.php Outdated Show resolved Hide resolved

paulbalandan force-pushed the failing-tests branch from 447224d to 98ed6f5 Compare

July 20, 2023 06:59

kenjis reviewed

View reviewed changes

tests/system/Commands/Utilities/NamespacesTest.php Outdated Show resolved Hide resolved

kenjis reviewed

View reviewed changes

tests/system/Commands/Utilities/NamespacesTest.php Outdated Show resolved Hide resolved

kenjis reviewed

View reviewed changes

tests/system/Commands/Utilities/NamespacesTest.php Outdated Show resolved Hide resolved

kenjis reviewed

View reviewed changes

tests/system/Commands/Utilities/NamespacesTest.php Outdated Show resolved Hide resolved


          Fix failures due to line ending

75d87ed

paulbalandan force-pushed the failing-tests branch from 98ed6f5 to 5319cff Compare

July 25, 2023 05:51


          Fix failures due to path in heredoc

ccbfcfa

paulbalandan force-pushed the failing-tests branch from 5319cff to ccbfcfa Compare

July 25, 2023 05:53

kenjis approved these changes

View reviewed changes

MGatner approved these changes

View reviewed changes

tests/system/Commands/Utilities/NamespacesTest.php

@@ @@ -35,9 +35,16 @@ protected function tearDown(): void @@
                       $this->resetServices();
                   }
+                  /**
+                   * @see https://regex101.com/r/l3lHfR/1

Member

MGatner Jul 25, 2023

Thanks for that 😅

kenjis merged commit f6d834e into codeigniter4:develop

paulbalandan deleted the failing-tests branch

July 25, 2023 23:49

TimexPeachtree approved these changes

View reviewed changes

TimexPeachtree left a comment

Great for windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet