Fix generics signature of config()
and model()
#7660
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the current undocumented behavior of
config()
andmodel()
is to allow any class string as name input and return their respective instances, then I believe we should change the generics signature to account this fact.How to test
test.php
vendor/bin/phpstan analyse -v test.php
In line 7, PHPStan gives the inferred type as
App|null
since it does not know ifApp
is a valid class string or not. In PHPStan parlance, this is a "maybe" class string, thus it can beApp
ornull
. More precise type inference will come once our own phpstan extension is out, which is currently in development.This PR also fixes the resulting error in code in Toolbar.
Related: #7224 #7254
Checklist: