Skip to content

docs: fix view_cells.rst #7457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 27, 2023
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 27, 2023

Description

  • improve sample code
  • fix minor incorrect descriptions

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis force-pushed the fix-docs-view-cells branch from 4d2de0f to a1e3a68 Compare April 27, 2023 02:32
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some requests for changes. Some are unrelated to the changes you made here, but since you're polishing the user guide, I thought you would be okay with making them.

@kenjis kenjis force-pushed the fix-docs-view-cells branch from a1e3a68 to 4cde712 Compare April 27, 2023 08:07
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@kenjis kenjis added the documentation Pull requests for documentation only label Apr 27, 2023
@kenjis kenjis merged commit e4438f7 into codeigniter4:develop Apr 27, 2023
@kenjis kenjis deleted the fix-docs-view-cells branch April 27, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants