Skip to content

docs: remove :noindex: #7360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2023
Merged

docs: remove :noindex: #7360

merged 1 commit into from
Mar 20, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 18, 2023 •
edited
Loading

Description
:noindex: makes the item unlinkable.

See https://codeigniter4.github.io/CodeIgniter4/incoming/incomingrequest.html#CodeIgniter\HTTP\IncomingRequest::getGetPost
getCookie() has no id, and we cannot make a link to it.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Mar 18, 2023
@paulbalandan paulbalandan merged commit d97b04b into codeigniter4:develop Mar 20, 2023
@kenjis kenjis deleted the fix-docs-rm-noindex branch March 20, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totoprayogo1916 totoprayogo1916 totoprayogo1916 approved these changes

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @totoprayogo1916 @MGatner @paulbalandan