Skip to content

[Rector] Enable skipped RemoveUselessReturnTagRector #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2022
Merged

[Rector] Enable skipped RemoveUselessReturnTagRector #7031

merged 2 commits into from
Dec 28, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 28, 2022 •
edited
Loading

Description

RemoveUselessReturnTagRector already cover @return true

Checklist:

  • Securely signed commits

@samsonasik
[Rector] Enable skipped RemoveUselessReturnTagRector
f0700a5 
`RemoveUselessReturnTagRector` already cover `@return true`
@samsonasik
add trailing comma
4b78a2e
@samsonasik samsonasik added the 4.3 label Dec 28, 2022
@samsonasik samsonasik requested a review from kenjis December 28, 2022 04:00
kenjis
kenjis approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samsonasik samsonasik merged commit 6f1cb11 into 4.3 Dec 28, 2022
@samsonasik samsonasik deleted the samsonasik-patch-1 branch December 28, 2022 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @kenjis