Skip to content

fix: make note PR branch to comment only #6580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2022
Merged

fix: make note PR branch to comment only #6580

merged 1 commit into from
Sep 24, 2022

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Sep 24, 2022 •
edited
Loading

Description
I think make this comment only, if everyone who made PR didn't show this info.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

MGatner
MGatner approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you! So many people just submit without updating.

@MGatner MGatner merged commit 106102f into codeigniter4:develop Sep 24, 2022
@ddevsr ddevsr deleted the patch-1 branch September 24, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddevsr @kenjis @MGatner