Skip to content

docs: improve time.rst #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 14, 2022

Description

  • fix RST format
  • improve explanation of toDateTimeString() toDateString() toTimeString()

Related #6116

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Jun 14, 2022
@kenjis
Copy link
Member Author

kenjis commented Jun 14, 2022

@datamweb Can you check the outputs (015.php to 018.php) of locale fa? No problem?
https://github.com/codeigniter4/CodeIgniter4/pull/6121/files#diff-028e477d26b38806ea1c51981970c3ae643615ba98d6eca76c7315344f8625e7

@datamweb
Copy link
Contributor

@kenjis Please edit: improve explanation of toDateTimeString() toDateTimeString() ...

The output is according to what you wrote And I do not see a problem

Screenshot 2022-06-14 120419

It may be useful.
As a reminder for Iranians. Since we have our own calendar, you must use auxiliary functions to convert the date.
An example of this is JDF HELPER.
The output is as follows:

       helper(['jdf']);
       echo gregorian_to_jalali(2016,03,9,'/'); // 1394/12/19 (۱۳۹۴/۱۲/۱۹)

@kenjis
Copy link
Member Author

kenjis commented Jun 14, 2022

The output is according to what you wrote And I do not see a problem

Thank you!

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer.

@kenjis kenjis merged commit 3587358 into codeigniter4:develop Jun 14, 2022
@kenjis kenjis deleted the fix-docs-time.rst branch June 14, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants