Skip to content

Remove semicolons from SQL statements. #5513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2021
Merged

Remove semicolons from SQL statements. #5513

merged 1 commit into from
Dec 29, 2021

Conversation

ytetsuro
Copy link
Contributor

@ytetsuro ytetsuro commented Dec 29, 2021 •
edited
Loading

Description

Removed unnecessary semicolons.
The reason is the following.

  • In oci_parse, if there is a semicolon, it is treated as PL/SQL.
  • There is no semicolon at the end of the SQL except for the one fixed here.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ytetsuro ytetsuro mentioned this pull request Dec 29, 2021
Merged
5 tasks
@samsonasik samsonasik requested a review from michalsn December 29, 2021 07:20
@kenjis kenjis merged commit ac84d20 into codeigniter4:develop Dec 29, 2021
@ytetsuro
Copy link
Contributor Author

Thansk merged!

@kenjis kenjis added database Issues or pull requests that affect the database layer refactor Pull requests that refactor code labels Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
database Issues or pull requests that affect the database layer refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ytetsuro @kenjis @michalsn