Skip to content

Annotate specifically designed slow tests with custom limits #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paulbalandan
Copy link
Member

Checklist:

  • Securely signed commits

@paulbalandan paulbalandan requested a review from MGatner May 21, 2021 07:30
@MGatner
Copy link
Member

MGatner commented May 21, 2021

I realize you are cherry picking intentionally slow tests, but if you go through any complete test classes and consider them "done" then let's add Expeditable as a way of indicating that class is ready for the overall change.

@paulbalandan
Copy link
Member Author

I'll do that over the weekend.

@paulbalandan paulbalandan merged commit 866e271 into codeigniter4:develop May 21, 2021
@paulbalandan paulbalandan deleted the slow-tests-annotation branch May 21, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants