Skip to content

chore: update cap-app-proxy image tags to 1.3688.0 - fix eventBusName when using jetstream #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2025
Merged

chore: update cap-app-proxy image tags to 1.3688.0 - fix eventBusName when using jetstream #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
725fda4
chore: update cap-app-proxy image tags to 1.3688.0 - fix eventBusName…
ATGardner Aug 3, 2025
3a6ce5e
improve labels on different *-reporter components
ATGardner Aug 3, 2025
70599e0
fixed templating, added label to rollout-reporter crb
ATGardner Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions charts/gitops-runtime/templates/_components/event-reporters/rollout-reporter/_rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ kind: Role
metadata:
name: rollout-reporter-sa
labels:
app.kubernetes.io/part-of: rollout-reporter
codefresh.io/internal: "true"
{{- include "event-reporters.rollout-reporter.labels" . | nindent 4}}
rules:
- apiGroups:
- "*"
Expand All @@ -19,8 +18,7 @@ kind: RoleBinding
metadata:
name: rollout-reporter-sa
labels:
app.kubernetes.io/part-of: workflow-reporter
codefresh.io/internal: "true"
{{- include "event-reporters.rollout-reporter.labels" . | nindent 4}}
roleRef:
apiGroup: ""
kind: Role
Expand Down
3 changes: 1 addition & 2 deletions charts/gitops-runtime/templates/_components/event-reporters/workflow-reporter/_rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ kind: RoleBinding
metadata:
name: workflow-reporter
labels:
app.kubernetes.io/part-of: workflow-reporter
codefresh.io/internal: "true"
{{- include "event-reporters.workflow-reporter.labels" . | nindent 4 }}
roleRef:
apiGroup: ""
kind: Role
Expand Down
2 changes: 2 additions & 0 deletions charts/gitops-runtime/templates/event-reporters/rollout-reporter/clusterrolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: codefresh-rollouts-reporter
labels:
{{- include "event-reporters.rollout-reporter.labels" . | nindent 4}}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
Expand Down
2 changes: 1 addition & 1 deletion charts/gitops-runtime/templates/eventbus/codefresh-eventbus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ metadata:
annotations:
{{- .Values.global.runtime.eventBus.annotations | toYaml | nindent 4}}
labels:
app.kubernetes.io/part-of: argo-events
app.kubernetes.io/part-of: codefresh-eventbus
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed, for a more specific labelSelector for EventBus, used by app-proxy code

codefresh.io/internal: "true"
spec:
{{- $eventBusSpec | toYaml | nindent 2}}
4 changes: 2 additions & 2 deletions charts/gitops-runtime/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,14 +564,14 @@ app-proxy:
tag: 1.1.14-main
image:
repository: quay.io/codefresh/cap-app-proxy
tag: 1.3680.0
tag: 1.3688.0
pullPolicy: IfNotPresent
# -- Extra volume mounts for main container
extraVolumeMounts: []
initContainer:
image:
repository: quay.io/codefresh/cap-app-proxy-init
tag: 1.3680.0
tag: 1.3688.0
pullPolicy: IfNotPresent
command:
- ./init.sh
Expand Down