chore(app-proxy): add ServiceMonitor configuration for metrics monitoring #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ServiceMonitor resource definition to enable monitoring of the app-proxy's http-metrics endpoint. This change allows for better observability and performance tracking of the service.
mikhail-klimko
requested changes
May 21, 2025
charts/gitops-runtime/values.yaml
Outdated
| @@ -592,6 +592,11 @@ app-proxy: | |||
| annotations: {} | |||
| name: "cap-app-proxy" | |||
|
|
|||
| serviceMonitor: | |||
| create: true | |||
There was a problem hiding this comment.
@ATGardner Can you change it to enabled: false?
- We have a general convention to use
enabledword - And I suggest to disable it by default, not all customers have ServiceMonitor CRD installed
There was a problem hiding this comment.
sure. i used create similarly to the serviceAccount. but i guess this is a bit different. changing now
Change the ServiceMonitor configuration to use an 'enabled' flag instead of 'create'. This allows for better control over the monitoring setup in the app-proxy.
mikhail-klimko
approved these changes
May 21, 2025
|
/e2e |
dmaizel
approved these changes
May 21, 2025
|
/e2e |
1 similar comment
|
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ServiceMonitor resource definition to enable monitoring of the app-proxy's http-metrics endpoint. This change allows for better observability and performance tracking of the service.
What
Why
Notes