-
Notifications
You must be signed in to change notification settings - Fork 9
feat: limits enforcement in runtime installation #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4372452
feat: limits enforcement in runtime installation
andrii-codefresh 2819447
use new cli-v2
andrii-codefresh 2f057c7
use new cli-v2
andrii-codefresh a4fd356
Merge remote-tracking branch 'origin/main' into CR-28342-usage
andrii-codefresh 8bd0e2a
test
andrii-codefresh 96ef93f
values in volume
andrii-codefresh afa03bc
remove test values
andrii-codefresh c776d7a
separate volume and SA
andrii-codefresh f3fd2a6
hook-weight
andrii-codefresh 7f77712
Merge remote-tracking branch 'origin/main' into feat/CR-28342-usage
andrii-codefresh 75bd601
hook-weight
andrii-codefresh f09d719
fix template, use image
andrii-codefresh fb8c38d
trigger commit
andrii-codefresh 306a9aa
Merge remote-tracking branch 'origin/main' into feat/CR-28342-usage
andrii-codefresh 84ddf24
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/CR-…
andrii-codefresh 16c0df4
Merge remote-tracking branch 'origin/main' into feat/CR-28342-usage
andrii-codefresh 244af27
trigger commit
andrii-codefresh 60c3199
role
andrii-codefresh 00910f3
Merge remote-tracking branch 'origin/main' into feat/CR-28342-usage
andrii-codefresh c556bb4
trigger commit
andrii-codefresh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
charts/gitops-runtime/templates/hooks/pre-install/validate-usage.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
{{- if not .Values.installer.skipUsageValidation }} | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: validate-values-config | ||
annotations: | ||
helm.sh/hook: pre-install | ||
helm.sh/hook-delete-policy: hook-succeeded,before-hook-creation,hook-failed | ||
helm.sh/hook-weight: "-10" | ||
andrii-codefresh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
data: | ||
values.yaml: | | ||
{{ .Values | toYaml | indent 4 }} | ||
|
||
--- | ||
apiVersion: batch/v1 | ||
kind: Job | ||
metadata: | ||
name: validate-usage | ||
annotations: | ||
helm.sh/hook: pre-install | ||
helm.sh/hook-delete-policy: hook-succeeded,before-hook-creation | ||
spec: | ||
backoffLimit: 0 | ||
ttlSecondsAfterFinished: 300 | ||
template: | ||
spec: | ||
serviceAccountName: validate-values-sa | ||
andrii-codefresh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
restartPolicy: Never | ||
containers: | ||
- name: validate-usage | ||
image: "{{ .Values.installer.image.repository }}:{{ .Values.installer.image.tag | default .Chart.Version }}" | ||
imagePullPolicy: {{ .Values.installer.image.pullPolicy }} | ||
env: | ||
- name: NAMESPACE | ||
valueFrom: | ||
fieldRef: | ||
fieldPath: metadata.namespace | ||
command: ["sh", "-c"] | ||
args: | ||
- | | ||
cf account validate-usage --fail-condition=reached --subject=clusters --values /job_tmp/values.yaml --namespace ${NAMESPACE} --hook --log-level debug | ||
volumeMounts: | ||
- name: customized-values | ||
mountPath: "/job_tmp" | ||
volumes: | ||
- name: customized-values | ||
configMap: | ||
name: validate-values-config | ||
{{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.