Skip to content

feat(runner): add codefreshToken as output for helm-based installation #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* [email protected] [email protected] [email protected] [email protected]
5 changes: 5 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## What

## Why

## Notes
13 changes: 7 additions & 6 deletions lib/interface/cli/commands/hybrid/init.cmd.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,14 @@ function printInstallationOptionsSummary({
dryRun,
shouldUseHelm,
}) {
let summary = `\n${colors.green('Installation options summary:')}
let summary = `\n${colors.green('Installation options summary:')}
1. Kubernetes Context: ${colors.cyan(kubeContextName)}
2. Kubernetes Namespace: ${colors.cyan(kubeNamespace)}
3. Set this as default account runtime-environment: ${colors.cyan(!!shouldMakeDefaultRe)}
4. Execute demo pipeline after install: ${colors.cyan(!!shouldExecutePipeline)}
5. HTTP proxy: ${httpProxy ? colors.cyan(httpProxy) : 'none'}
6. HTTPS proxy: ${httpsProxy ? colors.cyan(httpsProxy) : 'none'}
7. No proxy: ${noProxy ? colors.cyan(noProxy) : 'none'}
6. HTTPS proxy: ${httpsProxy ? colors.cyan(httpsProxy) : 'none'}
7. No proxy: ${noProxy ? colors.cyan(noProxy) : 'none'}
`;

if (appProxy) {
Expand Down Expand Up @@ -845,7 +845,7 @@ const initCmd = new Command({
return true;
}

const monitoringToken = _.get(sdk, 'config.context.token');
const userToken = _.get(sdk, 'config.context.token');

// install monitoring
installationPlan.addStep({
Expand All @@ -862,7 +862,7 @@ const initCmd = new Command({
'set-file': setFile,
'dry-run': dryRun,
'bypass-download': bypassDownload,
token: monitoringToken,
token: userToken,
verbose,
noExit: true, // to prevent if from calling inner: process.exit()
url,
Expand Down Expand Up @@ -891,7 +891,7 @@ const initCmd = new Command({
const monitor = {
enabled: shouldInstallMonitoringFn(),
clusterId: kubeContextName,
token: monitoringToken,
token: userToken,
};

const global = {
Expand All @@ -902,6 +902,7 @@ const initCmd = new Command({
agentName: agent.name,
accountId: agent.account,
runtimeName: runtimeNameContext,
codefreshToken: userToken,
keys,
};

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "codefresh",
"version": "0.84.7",
"version": "0.84.8",
"description": "Codefresh command line utility",
"main": "index.js",
"preferGlobal": true,
Expand Down Expand Up @@ -115,4 +115,4 @@
"./test-setup.js"
]
}
}
}