Fix compilation for master version of godot (soon to be beta 9)#51
Merged
codecat merged 2 commits intocodecat:masterfrom Dec 19, 2022
Merged
Fix compilation for master version of godot (soon to be beta 9)#51codecat merged 2 commits intocodecat:masterfrom
codecat merged 2 commits intocodecat:masterfrom
Conversation
Owner
|
Thanks! I will merge this PR when Beta 9 comes out. Feel free to ping me in case I miss the release. |
Contributor
Author
|
@codecat well, beta 9 it's out and godot-cpp doesn't have an update so this is ready to merge |
Contributor
Author
|
Added latest changes for godot-cpp, did a quick test and works as before |
Owner
|
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested with a master version of godot and tbloader make it crash. Updating godot-cpp it's not enough to make it compile since there was also renames (They have the new names on the README so it was easy). This changes make it work again. I did a quick test and appears to work as before.