Update for nullability changes in 15.0.0-p.12

[cmeeren]

@michaelstaib, I'm having problems due to this change in 15.0.0-p.12, which removed some Option<_> unwrapping I was not aware was present in the core of HotChocolate.

I am trying to modify FSharp.HotChocolate to account for this (not committed/pushed yet). I am now removing Option wrappers myself, so now the field/argument types are correct (and correctly queryable), but the schema is still full of unused/unreachable types like this:

type FSharpOptionOfDouble {
  get_Value: Float!
  value: Float!
}

Again, these are unused/unreachable. For example, this particular type appears if I have a field that returns Option<double> (which, in the schema, is correctly typed as Float, not FSharpOptionOfDouble).

Why is that happening, and what can I do about it? (Apart from .TrimTypes(), which I obviously don't want to force on our users, and which doesn't fix the root issue.)

[michaelstaib]

Yes, we removed FSharp related code from the core as with your package we do not see need for ours. However we will have new hooks that you can tap into the core. However, at the moment we are just doing some realignment for the main project, so we kick things out but have not yet put any new things in.

[cmeeren]

Thanks for the quick reply! So there is nothing for me to do except wait for p.13 (or whichever release this will be present in)?

Could I bother you to post a comment here when and how I can use the new API?

[michaelstaib]

I still have to think about how we redesign the type inspection. We need to prepare the type inspection to allow for providers as we also want to use source generators for C# here, but for F# you might want to stay on the reflection API or tap into F# source generators once they arrive,

[michaelstaib]

Yes, nothing todo yet, I will ping you once we untangled the type inspection.

[cmeeren]

Hi, now that v15 is out, could you help me with FSharp.HotChocolate? Currently it's completely broken, as described in the OP (hopefully not a complicated fix, but I don't know what).

[cmeeren]

Hi @michaelstaib, just a reminder about this. 🙂 I'm dependent on your help and that "knowledge transfer" you have talked about previously, in order to update this library for v15, so that F# users are able to use HC 15.

[cmeeren]

This is now supported.

References:
ChilliCream/graphql-platform#8088
ChilliCream/graphql-platform#8722
ChilliCream/graphql-platform#8732

[mta-incom]

@cmeeren Any updates on a release of this issue?
As far as i can see the changes required in HC were added in HC 15.1.11

But the fix for it in FSharp.HotChocolate (here: 763d184) has not yet been released and the change targets a pre-release candidate (16.0.0-p.8.4) of HC rather than the latest stable.

Any updates would be much appreciated.

[cmeeren]

I'm waiting for the non-prerelease HC 16.0. When that is out, I can update and release FSharp.HotChocolate (which will then require HC 16).