Skip to content

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Jan 17, 2024

This pull request builds on top of #13 and #9.

References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33 and others.

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@SimonFrings SimonFrings added this to the v0.3.0 milestone Jan 22, 2024
@SimonFrings SimonFrings requested a review from clue February 2, 2024 14:42
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit 18475df into clue:master Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants