Skip to content

Release v1.7.0 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Release v1.7.0 #52

merged 1 commit into from
May 23, 2025

Conversation

PaulRotmann
Copy link
Collaborator

@PaulRotmann PaulRotmann commented May 6, 2025

This pull request updates the changelog and documentation for the upcoming release.

@PaulRotmann PaulRotmann changed the title Preparation for release v1.7.0 Prepare release v1.7.0 May 23, 2025
@PaulRotmann PaulRotmann changed the title Prepare release v1.7.0 Prepare v1.7.0 release May 23, 2025
@PaulRotmann PaulRotmann changed the title Prepare v1.7.0 release Release v1.7.0 May 23, 2025
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulRotmann LGTM, let's get this shipped! :shipit:

@clue clue added this to the v1.7.0 milestone May 23, 2025
@PaulRotmann PaulRotmann merged commit 0b6b9b0 into clue:1.x May 23, 2025
14 checks passed
@clue
Copy link
Owner

clue commented May 23, 2025

For future reference, we're still working out this PR release workflow and this marks the first time I've created a release + tag using GitHub's UI for this release right after merging this PR here.

Unfortunately, GitHub apparently only creates a lightweight tag and not an annotated tag, which in turn goes against git best practices:

Annotated tags are meant for release while lightweight tags are meant for private or temporary object labels. For this reason, some git commands for naming objects (like git describe) will ignore lightweight tags by default.

https://git-scm.com/docs/git-tag

This has been reported to GitHub a while ago and doesn't look like something that's going to change anytime soon (https://github.com/orgs/community/discussions/4924).

I've created an annotated tag locally and force-pushed this over the lightweight tag to fix this. Not ideal (https://www.reddit.com/r/git/comments/45qpg8/is_it_considered_bad_practice_to_replace_a/), but both tags should point to the same source commit 0b6b9b0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants