await: throw Throwables #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react/promise supports Throwables and so should await(). Nested exceptions make it trickier to track down the root cause of a failing promise-ized construct
|
@Thomas-Gelf Thanks for looking into this and filing this PR! The changes look perfectly reasonable to me, but unfortunately this introduces a small BC break with regards to what types this project will throw. The original feature was introduced via #7/#27/#42. What do you think about this? I'm also happy to jump on a quick call to discuss this in person if you want (see my profile for details) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react/promise supports Throwables and so should await(). Nested exceptions
make it trickier to track down the root cause of a failing promise-ized
construct