Skip to content

Conversation

jayantxie
Copy link
Member

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners June 19, 2025 07:46
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.21%. Comparing base (4cfae2c) to head (8efbad4).

Files with missing lines Patch % Lines
pkg/retry/util.go 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
- Coverage   60.26%   60.21%   -0.06%     
==========================================
  Files         381      381              
  Lines       34514    34483      -31     
==========================================
- Hits        20799    20763      -36     
- Misses      12450    12455       +5     
  Partials     1265     1265              
Flag Coverage Δ
integration 48.61% <83.33%> (+<0.01%) ⬆️
unit 50.78% <92.59%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jayantxie jayantxie force-pushed the fix/retry_race branch 4 times, most recently from 47ef62c to eb5f1b7 Compare June 19, 2025 08:20
if v == nil {
return nil
}
rv := reflect.ValueOf(v)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeOf 可以简单点。还不用判断 Nil

@jayantxie jayantxie force-pushed the fix/retry_race branch 2 times, most recently from a942cff to 707f1f7 Compare August 4, 2025 14:46
@jayantxie jayantxie marked this pull request as draft August 5, 2025 03:14
@jayantxie jayantxie force-pushed the fix/retry_race branch 3 times, most recently from f5cb970 to e8b6814 Compare August 11, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants