refactor(adk): rename constructors to New() for ChatModelAgentMiddleware#761
Merged
refactor(adk): rename constructors to New() for ChatModelAgentMiddleware#761
Conversation
…tMiddleware - skill: keep New (deprecated), NewHandler -> NewChatModelAgentMiddleware - filesystem: NewChatModelAgentMiddleware -> New - reduction: NewToolReductionMiddleware -> New
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // NewToolReductionMiddleware creates tool reduction middleware from config | ||
| func NewToolReductionMiddleware(_ context.Context, config *ToolReductionMiddlewareConfig) (mw adk.ChatModelAgentMiddleware, err error) { | ||
| // New creates tool reduction middleware from config | ||
| func New(_ context.Context, config *ToolReductionMiddlewareConfig) (mw adk.ChatModelAgentMiddleware, err error) { |
There was a problem hiding this comment.
🚨 Breaking API Changes Detected
Package: github.com/cloudwego/eino/adk/middlewares/reduction
Incompatible changes:
- NewToolReductionMiddleware: removed
Review Guidelines
Please ensure that:
- The changes are absolutely necessary
- They are properly documented
- Migration guides are provided if needed
hi-pender
changed the title
| "compose", | ||
| "deep", | ||
| "dynamictool", | ||
| "filesystem", |
There was a problem hiding this comment.
🚨 Breaking API Changes Detected
Package: github.com/cloudwego/eino/adk/middlewares/patchtoolcalls
Incompatible changes:
- Config: removed
- NewMiddleware: removed
Review Guidelines
Please ensure that:
- The changes are absolutely necessary
- They are properly documented
- Migration guides are provided if needed
meguminnnnnnnnn
approved these changes
Feb 5, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha/08 #761 +/- ##
===========================================
Coverage ? 79.78%
===========================================
Files ? 146
Lines ? 15805
Branches ? 0
===========================================
Hits ? 12610
Misses ? 2218
Partials ? 977 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hi-pender
added a commit
that referenced
this pull request
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
统一 middleware 包的构造函数命名规范，使返回
ChatModelAgentMiddleware的构造函数使用New()作为主要入口。Changes
NewAgentMiddlewareNewChatModelAgentMiddlewareChatModelAgentMiddlewareNewHandler）NewChatModelAgentMiddlewareNewChatModelAgentMiddlewareNewChatModelAgentMiddlewareNewToolReductionMiddlewareRationale
skill包保持New函数不变以保持向后兼容性filesystem和reduction包由于原来没有New()函数，可以直接使用New()作为主要构造函数