Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hi-pender
force-pushed
the
gcb/skill_filesystem
branch
from
f41614c to
20e9211
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha/08 #753 +/- ##
===========================================
Coverage ? 80.29%
===========================================
Files ? 145
Lines ? 15628
Branches ? 0
===========================================
Hits ? 12549
Misses ? 2106
Partials ? 973 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hi-pender
force-pushed
the
gcb/skill_filesystem
branch
from
fceac2f to
e5f0cb8
Compare
…d on filesystem.Backend interface - Remove LocalBackend that directly uses os package - Add filesystemBackend that wraps filesystem.Backend interface - Simplify list() method by directly attempting to read SKILL.md - Export Backend interface, unexport implementation details - Update tests to use filesystem.InMemoryBackend
… of error string matching
- Use GlobInfo with pattern '*/SKILL.md' to find skill files - Fix InMemoryBackend.GlobInfo to match relative paths correctly - Fix test expectation in TestInMemoryBackend_GlobInfo
hi-pender
force-pushed
the
gcb/skill_filesystem
branch
from
e5f0cb8 to
da0bc81
Compare
…esystem and remove Read Limit - Rename NewFilesystemBackend to NewBackendFromFilesystem for clarity - Remove explicit Limit parameter in Read, use default behavior
hi-pender
changed the title
meguminnnnnnnnn
approved these changes
Feb 4, 2026
hi-pender
added a commit
that referenced
this pull request
Feb 14, 2026
… filesystem.Backend interface (#753)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the skill middleware to use
filesystem.Backendinterface instead of directospackage operations, making the implementation more unified and testable.Changes
LocalBackendthat directly usesospackage for file operationsfilesystemBackend(unexported) that wrapsfilesystem.Backendinterfacelist()method by directly attempting to readSKILL.mdfilesBackendinterface, unexport implementation detailslocal.go→filesystem_backend.go,local_test.go→filesystem_backend_test.gofilesystem.InMemoryBackendfor better testabilityBenefits
filesystem.BackendinterfaceInMemoryBackendfor testing without real filesystemReadmethod behavior