Add missing supports implementations in SQL generation code
#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
approved these changes
Oct 21, 2021
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: remove extraneous empty line
There was a problem hiding this comment.
Should be resolved now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing
supportsimplementations within the Spanner SQL generator. Without these methods, Liquibase will always generate code in the Spanner dialect without taking into account the type of database.Whilst this is not an issue when Spanner is the only configured database, when there are multiple database types in use these missing methods cause Liquibase to incorrectly use the Spanner dialect, breaking migration functionality.