Conversation
href
force-pushed
the
denis/stable-tests
branch
2 times, most recently
from
a4b89e7 to
f1c0b0d
Compare
This is not the time we want to end up at, but with this change we can gather metrics on this particular test, that keeps taking longer than anticipated. Further, we no longer continue with the test if the peeraddr deployment was not successful.
There was a race that would sometimes return a service, before it had received its load balancer addresses, causing some tests to fail rarely and randomly.
href
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests have not been stable as of late. With this change we eliminate a race condition, and we add more time to a test that sometime takes longer than expected.
The additional time may be lowered again in the future: For now we are able to show the time it takes, instead of just giving up early.