[MRG][BRANCH-0.4.x] Regression on pickling classes from the __main__ module #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
HyukjinKwon
changed the title
|
Seems the test failure is by #151. |
HyukjinKwon
commented
Feb 5, 2018
|
|
||
| cloned = subprocess_pickle_echo(f4) | ||
| assert cloned(2) == f4(2) | ||
| """ |
There was a problem hiding this comment.
I removed protocol comparing to the original
| @@ -28,9 +29,13 @@ def subprocess_pickle_echo(input_data): | |||
|
|
|||
| """ | |||
| pickled_input_data = dumps(input_data) | |||
|
Since I merged the other, I think you can rebase this branch now. |
This reverts commit d9e02fb.
HyukjinKwon
force-pushed
the
backport-132
branch
from
e0fa85b to
3cfc303
Compare
Codecov Report
@@ Coverage Diff @@
## 0.4.x #149 +/- ##
=========================================
- Coverage 83.9% 83.58% -0.32%
=========================================
Files 1 1
Lines 528 530 +2
Branches 96 97 +1
=========================================
Hits 443 443
- Misses 63 64 +1
- Partials 22 23 +1
Continue to review full report at Codecov.
|
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Mar 8, 2018
## What changes were proposed in this pull request? The version of cloudpickle in PySpark was close to version 0.4.0 with some additional backported fixes and some minor additions for Spark related things. This update removes Spark related changes and matches cloudpickle [v0.4.3](https://github.com/cloudpipe/cloudpickle/releases/tag/v0.4.3): Changes by updating to 0.4.3 include: * Fix pickling of named tuples cloudpipe/cloudpickle#113 * Built in type constructors for PyPy compatibility [here](cloudpipe/cloudpickle@d84980c) * Fix memoryview support cloudpipe/cloudpickle#122 * Improved compatibility with other cloudpickle versions cloudpipe/cloudpickle#128 * Several cleanups cloudpipe/cloudpickle#121 and [here](cloudpipe/cloudpickle@c91aaf1) * [MRG] Regression on pickling classes from the __main__ module cloudpipe/cloudpickle#149 * BUG: Handle instance methods of builtin types cloudpipe/cloudpickle#154 * Fix <span>#</span>129 : do not silence RuntimeError in dump() cloudpipe/cloudpickle#153 ## How was this patch tested? Existing pyspark.tests using python 2.7.14, 3.5.2, 3.6.3 Author: Bryan Cutler <[email protected]> Closes apache#20373 from BryanCutler/pyspark-update-cloudpickle-42-SPARK-23159.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #132 to branch-0.4.x and fixes #131.