fix: avoid to use http.DefaultServeMux which includes defaults routes inited by go like /debug/pprof #1771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aauren
requested changes
Nov 28, 2024
There was a problem hiding this comment.
Can you also do the same for the health controller as well? https://github.com/cloudnativelabs/kube-router/blob/master/pkg/healthcheck/health_controller.go#L223-L226
pkg/metrics/metrics_controller.go
Outdated
| @@ -260,13 +260,15 @@ func (mc *Controller) Run(healthChan chan<- *healthcheck.ControllerHeartbeat, st | |||
| DefaultRegisterer.MustRegister(BuildInfo) | |||
| DefaultRegisterer.MustRegister(ControllerIpvsMetricsExportTime) | |||
|
|
|||
| mux := &http.ServeMux{} | |||
There was a problem hiding this comment.
Small nit here, can you change this to http.NewServeMux() instead? It amounts to the same, but seems better to use the default function provided.
…inited by go like /debug/pprof
|
updated. |
aauren
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cs.opensource.google/go/go/+/refs/tags/go1.23.3:src/net/http/pprof/pprof.go;l=100
metrics may just metrics
if enable pprof in metrics server, the flags
--enable-pprofmay be confused.