Debug test failures #3654
Merged
Debug test failures #3654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
- Standardize PostgreSQL commands with `-h localhost` for clarity. - Improve robustness in scripts: add checks for file writability and existence. - Adjust Gradle logging for better visibility and lifecycle tracking. - Minor enhancements to integration and helper scripts for better error handling and output tracing.
- Removed jacocoCargoReport task from `build.gradle`. - Updated SonarQube Gradle plugin to version 7.0.1.6134
duanemay
force-pushed
the
debug-test-failures
branch
from
4248e60 to
78e0174
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on improving robustness and maintainability of the UAA build and test infrastructure. The changes include upgrading dependencies, adding debug logging, improving error handling in shell scripts, and removing unused code.
Key changes:
- Upgraded sonarqube plugin from version 6.3.1.5724 to 7.0.1.6134
- Enhanced shell script error handling with file existence checks and graceful fallbacks
- Added debug logging via
set -xin docker database startup script - Removed test logging configuration block and unused Jacoco cargo report task from Gradle build files
- Removed entire boot integration tests workflow file
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| uaa/build.gradle | Removed testLogging block and added lifecycle logging for UAA auto-start/stop events |
| scripts/start_docker_database.sh | Added debug mode (set -x) to trace docker commands |
| scripts/lib_util_helper.sh | Added file writability/existence checks before accessing /etc/hosts and /proc/meminfo; removed -q flag from grep |
| scripts/lib_ldap_helper.sh | Changed LDAP setup detection failure from exit to graceful skip |
| scripts/lib_db_helper.sh | Added -h localhost flag to all PostgreSQL psql commands and reformatted multi-line init_db command |
| scripts/integration_tests.sh | Added default value hsqldb for DB variable |
| dependencies.gradle | Upgraded sonarqube-gradle-plugin from 6.3.1.5724 to 7.0.1.6134 |
| build.gradle | Removed unused imports and jacocoCargoReport task definition |
| .github/workflows/boot-integration-tests.yml | Deleted entire workflow file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
scripts/lib_db_helper.sh
Outdated
Comment on lines
123
to
127
| init_db="psql -c 'drop database if exists uaa;' -h localhost -U postgres | ||
| psql -c 'create database uaa;' -h localhost -U postgres; | ||
| psql -c 'drop user if exists root;' -h localhost --dbname=uaa -U postgres; | ||
| psql -c \"create user root with superuser password '${db_password}';\" -h localhost --dbname=uaa -U postgres; | ||
| psql -c 'show max_connections;' -h localhost --dbname=uaa -U postgres;" |
There was a problem hiding this comment.
The multi-line command string is missing semicolons at the end of line 123. Since this is assigned to a variable and later executed with eval, the first command will fail. Line 123 should end with a semicolon: 'drop database if exists uaa;' -h localhost -U postgres;
strehle
approved these changes
Oct 30, 2025
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a lot of failures in workflows recently.
-h localhostfor clarity.