-
Notifications
You must be signed in to change notification settings - Fork 841
Cargo migration & Upgrade Gradle to version 9.0.0 #3648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo migration & Upgrade Gradle to version 9.0.0 #3648
Conversation
943a3ed to
766abb3
Compare
…tRestDocs gradle task after migrating to tasks.register()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Migrates from legacy Cargo/Tomcat setup to a Spring Boot-centric workflow and upgrades Gradle to 9.0.0.
- Replace references from scripts/cargo to scripts/boot and remove legacy Cargo/Tomcat initializer code.
- Upgrade Gradle wrapper to 9.0.0 and modernize build script with tasks.register and related adjustments.
- Update scripts and docs for Boot-based local and integration test workflows.
Reviewed Changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| uaa/src/test/java/org/cloudfoundry/identity/uaa/login/BootstrapTests.java | Points LOGIN_CONFIG_URL at scripts/boot/uaa.yml for tests. |
| uaa/src/test/java/org/cloudfoundry/identity/uaa/UaaWebApplicationInitializerTest.java | Removes test for the legacy servlet initializer. |
| uaa/src/main/java/org/cloudfoundry/identity/uaa/UaaWebApplicationInitializer.java | Removes the legacy servlet initializer (Tomcat/Cargo era). |
| uaa/src/main/java/org/cloudfoundry/experimental/boot/UaaBootApplication.java | Updates comment to reference scripts/boot. |
| uaa/build.gradle | Gradle 9 updates: task registration, repo syntax, test/doc tasks, and bootBuildImage config. |
| scripts/integration_tests.sh | Always boots the Spring Boot app for integration tests; switches config to scripts/boot. |
| scripts/cargo/uaa.yml | Removes legacy Cargo UAA config. |
| scripts/cargo/log4j2.properties | Removes legacy Cargo logging config. |
| scripts/boot/boot-with-tls.sh | Switches to scripts/boot config and inlines TLS server properties. |
| scripts/boot/application.yml | Removes TLS/server properties that are now passed via system properties. |
| k8s/README.md | Updates Docker examples to mount scripts/boot/uaa.yml. |
| gradle/wrapper/gradle-wrapper.properties | Upgrades Gradle wrapper to 9.0.0. |
| dependencies.gradle | Removes Cargo/Tomcat specific version pins and relies on BOM-managed versions; renames plugin var. |
| README.md | Updates run/debug instructions to Spring Boot (bootRun) and new config paths. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
uaa/src/test/java/org/cloudfoundry/identity/uaa/login/BootstrapTests.java
Show resolved
Hide resolved
…pts/boot/uaa.yml" correctly navigates from the uaa subdirectory up to the project root, then into scripts/boot/, so no need to use the classpath (which was not being loaded correctly and was making some tests to fail as this is some config needed for tests)
|
Questions
|
…be working with current boot application.
Thanks Filip, please find commit 7638cf1 to handle the |
Please find changes to handle 1. question in 309ba12 - |
No description provided.