Skip to content

Conversation

@cweibel
Copy link
Contributor

@cweibel cweibel commented Oct 9, 2025

Changes proposed in this pull request:

Security considerations

Increases the entropy making brute force attacks more difficult

@strehle strehle linked an issue Oct 9, 2025 that may be closed by this pull request
@strehle strehle requested a review from Copilot October 9, 2025 18:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the entropy of security tokens by extending the length of nonce and state parameters from their current values to 22 characters. This security enhancement makes brute force attacks more difficult by increasing the randomness of these critical OAuth/OIDC security parameters.

Key changes:

  • Increased nonce length from 12 to 22 characters in OIDC authentication flows
  • Increased state parameter length from 10 to 22 characters for OAuth flows

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cweibel
Copy link
Contributor Author

cweibel commented Oct 9, 2025

Added tests to check for the length of 22 for both state and nonce. Setting the values back to 10 and 12 respectively results in the tests failing.

@cweibel cweibel marked this pull request as ready for review October 9, 2025 20:28
@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Oct 14, 2025
@strehle strehle merged commit cedec71 into cloudfoundry:develop Oct 16, 2025
33 checks passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Extend length of nonce and state request header parameters

2 participants