Update database matrix to include MySQL 8.4 and 9, remove MySQL 5

[duanemay]

Also adds testing for 'postgresql-18'. Refactor the test scripts.

[Copilot]

Pull Request Overview

This PR updates the database matrix to support newer MySQL versions (8.4, 9) and PostgreSQL 18, while removing MySQL 5 support. The changes involve refactoring test scripts into modular library functions and updating the GitHub Actions workflows to use the new database versions.

Key changes:

• Updates database matrix to include MySQL 8.4, 9 and PostgreSQL 18, removes MySQL 5
• Refactors monolithic test scripts into modular library functions for database, LDAP, and utility helpers
• Updates GitHub Actions workflows to use new database versions and refactored scripts

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
.github/workflows/*.yml	Updates CI matrix to use new database versions and refactored script names
run-*.sh	Refactors main test runner scripts to use new modular library functions
scripts/lib_*.sh	New modular library functions for database, LDAP, and utility operations
scripts/*_tests.sh	New unified test scripts replacing old hyphenated versions
scripts/unit-tests*	Removes old unit test scripts
scripts/integration-tests*	Removes old integration test scripts
scripts/start_db_helper.sh	Removes old database helper in favor of new modular approach
Test files	Minor updates including keystore size increase and test assertion addition

Comments suppressed due to low confidence (2)

scripts/start_docker_database.sh:1

• The hardcoded '8.4' version in the stop command should be dynamic based on the actual database version being used. Consider using a variable like '${DOCKER_IMAGE}' or '${PROFILE_NAME}' instead.

#!/bin/bash

scripts/lib_db_helper.sh:1

• There's an extra space after '${db_password}' in the CREATE USER statement that will cause the password to include a trailing space, potentially breaking authentication.

#!/usr/bin/env bash

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[strehle]

thanks, in general we can go with this but only the debug is something you can think about

[Copilot]

Pull Request Overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

scripts/lib_db_helper.sh:1

• There's an extra space after '${db_password}' in the CREATE USER statement, which will result in a malformed password.

#!/usr/bin/env bash

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The hardcoded '8.4' in the stop command should be dynamic based on the actual database being used, similar to how the start command uses variables.

Suggested change

	docker stop \$(docker ps | grep 8.4 | tail -n 1 | awk '{print \$1}')
	docker stop \$(docker ps | grep ${DOCKER_IMAGE} | tail -n 1 | awk '{print \$1}')

[Copilot]

Pull Request Overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}