Jakarta Support #9
Conversation
nebhale
force-pushed
the
jakarta-support
branch
3 times, most recently
from
005d3fd to
500447e
Compare
There was a problem hiding this comment.
Thanks so much @nebhale for simplifying everything about Jakarta support!
Since we now deploy to Maven Central, we'll need a bit more XML to add developers, javadoc, licence, url and scm (like I did in the other PR)
But we'll add that with David when we test.
Please let me know about the PR comments I left! I'm curious to know your take on those.
Thanks again!
...te-mapper-jakarta/src/main/java/org/cloudfoundry/router/jakarta/ClientCertificateMapper.java
Outdated
Show resolved
Hide resolved
...te-mapper-jakarta/src/main/java/org/cloudfoundry/router/jakarta/ClientCertificateMapper.java
Outdated
Show resolved
Hide resolved
| </plugin> | ||
| <plugin> | ||
| <groupId>org.jfrog.buildinfo</groupId> | ||
| <artifactId>artifactory-maven-plugin</artifactId> |
There was a problem hiding this comment.
I don't think this plugin utilization is relevant / needed anymore.
With a slight change to deploy.sh and the concourse pipeline , we conform to other Java experience projects and don't rely on plugins not coming from central.
There was a problem hiding this comment.
Feel free to remove as you desire.
This change updates the project to support both the javax and jakarta namespaces for JEE projects. It does this by creating two separate Maven projects, one for each, which are then shaded into a single JAR used by everyone. The contents of META-INF/services and META-INF/spring.factories route to the correct implementation preventing class loading problems. Signed-off-by: Ben Hale <[email protected]>
Signed-off-by: Ben Hale <[email protected]>
nebhale
force-pushed
the
jakarta-support
branch
from
891b3f7 to
209c8cd
Compare
|
Nudge @anthonydahanne. |
This change updates the project to support both the javax and jakarta namespaces for JEE projects. It does this by creating two separate Maven projects, one for each, which are then shaded into a single JAR used by everyone. The contents of
META-INF/servicesandMETA-INF/spring.factoriesroute to the correct implementation preventing class loading problems.