Support EFI (and other firmware options) support#37
Merged
Conversation
tpbrisco
changed the title
jpalermo
approved these changes
Aug 9, 2024
jpalermo
left a comment
jpalermo
left a comment
There was a problem hiding this comment.
Looks great to me. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #348 added support for EFI in stemcells versions 1.465 and later.
Virtualbox defaults to BIOS, resulting in unbootable stemcell images.
This change defaults to Virtualbox using EFI64 VMs, and introduces a cloud-config variable to select alternative firmware approaches (or "bios", for compatibility with older stemcells).
No general testing harness seems available; thus testing was done through creating a local CPI release, and going through builds to ascertain that the cloud property propagates through, and yields a working BOSH.