Skip to content

CI pipeline for maintaining the release#35

Draft
bgandon wants to merge 15 commits into
masterfrom
ci-pipeline
Draft

CI pipeline for maintaining the release#35
bgandon wants to merge 15 commits into
masterfrom
ci-pipeline

Conversation

@bgandon

@bgandon bgandon commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

Gstack has developed a Concourse pipeline and demonstrated ability to update dependencies and ship a new release v0.4.3 using it:

Submitted here for contribution to the CFF upstream.

Fixes #33.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Feb 16, 2024

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

@bgandon

bgandon commented Feb 16, 2024

Copy link
Copy Markdown
Contributor Author

I should rework the contribution branch so that it does not include the version bumps themselves. They make the code review difficult and I can always cherry-pick those later on.

@bgandon

bgandon commented Feb 16, 2024

Copy link
Copy Markdown
Contributor Author

Here we go, that's cleaner.

Worth to note, everything in the ci folder is generated from the pipeline template, except ci/settings.yml.

settings.yml is where all the Spruce customisations are. these are being merged on top of the generated pipeline.yml by the repipe script.

@rkoster rkoster requested review from a team, mvach and ystros and removed request for a team February 22, 2024 15:45
@rkoster

rkoster commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

As mentioned during working group meeting the shared golang scripts should be good to consume now: https://github.com/cloudfoundry/bosh-package-golang-release/tree/main/ci/tasks/shared

let "result+=$?"

echo -e "\n Running ginkgo tests..."
ginkgo -r .

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using go run github.com/onsi/ginkgo/v2/ginkgo here so that there isn't a need for a ginkgo binary to be installed in $PATH, and to ensure that the version used matches go.mod.

Example: https://github.com/cloudfoundry/bosh-agent/blob/main/bin/ginkgo#L5C1-L5C40

echo -e "\n Formatting packages..."
go fmt github.com/cppforlife/bosh-virtualbox-cpi/...
go fmt bosh-virtualbox-cpi/...
let "result+=$?"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes sense to use set -e instead of the result+=$? pattern. It reduces conditionals, and ensures the script fails early.

Example: https://github.com/cloudfoundry/bosh-agent/blob/main/bin/ginkgo#L2

@aramprice aramprice left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all these updates! I really appreciate the thoroughness, and attention to detail in this change.
I'm not super familiar with this CPI so I will defer to others as to the functional changes.

@bgandon

bgandon commented Feb 29, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the review, I'm going back to this

@rkoster

rkoster commented Mar 28, 2024

Copy link
Copy Markdown
Contributor

@bgandon are still planning on coming back to this, or should we merge it as is?

@rkoster rkoster marked this pull request as draft May 16, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting for Changes | Open for Contribution

Development

Successfully merging this pull request may close these issues.

Accessing distant VirtualBox through SSH fails with recent OpenSSH servers

3 participants