Skip to content

Bridged networking feature#23

Merged
rkoster merged 5 commits into
masterfrom
bridged-networking
Oct 19, 2021
Merged

Bridged networking feature#23
rkoster merged 5 commits into
masterfrom
bridged-networking

Conversation

@bgandon

@bgandon bgandon commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

This PR is extracted from #17, focusing only on the new “bridged networking” feature. The work has been rebased on top of #22.

Original PR description by @ships in #17:

  • you had a WIP branch on bridged networks topic which I have progressed further. it is working for me but may not be complete; please give feedback at your convenience.
  • right now, you cannot enable or create bridged networks -- so it is only useful in cases where the bridged interface already exists.

Plus, we've gathered here the documentation proposed by @aussielunix in aussielunix/bosh-virtualbox-cpi-release@4bc4844.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 13, 2021

Copy link
Copy Markdown

CLA Signed

The committers are authorized under a signed CLA.

@rkoster rkoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying out these changes I'm getting:

Deploying:
  Creating instance 'bosh/0':
    Creating VM:
      Creating vm with stemcell cid 'sc-3aec8f82-4493-4e13-63ef-6674f124c0b3':
        CPI 'create_vm' method responded with error: CmdError{"type":"Bosh::Clouds::CloudError","message":"Creating VM with agent ID '{{a2de8839-3e4f-4b05-78ea-06610d254e40}}': Configuring NIC
s: Expected to find network 'en0'","ok_to_retry":false}

Had to change network_device: "en0: Wi-Fi (Wireless)" to make it work. Maybe add some docs on how to find the right device name.

Auth: []ssh.AuthMethod{ssh.PublicKeys(keySigner)},
User: r.opts.Username,
Auth: []ssh.AuthMethod{ssh.PublicKeys(keySigner)},
HostKeyCallback: ssh.InsecureIgnoreHostKey(),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not seem related to the bridged networking feature. Maybe it does fix something but it is hard to tell without context. This should probably be its own PR.

Comment thread docs/networks-bridged.md
internal_gw: 192.168.43.3
internal_cidr: 192.168.43.0/24
outbound_network_name: NatNetwork
network_device: en0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note that this network_device name can be found using VBoxManage list bridgedifs . In my case on MacOS I had to use network_device: "en0: Wi-Fi (Wireless)".

}
if testSSHRunnerHost == "" {
testSSHRunnerHost = "127.0.0.1"
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR

It("returns proper home directory", func() {
opts := SSHRunnerOpts{
Host: "127.0.0.1",
Host: testSSHRunnerHost,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR

@bgandon

bgandon commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

This PR contains patches from the fix-ssh-host-key-regression branch, because “The work has been rebased on top of #22.” as mentioned in the description.

I'll rebase on top of master in order to separate things more clearly.

between host-only and bridged.

right now, you cannot create Bridged.
this is "correct" in the sense that
virtualbox does not create bridged devices
for you. however, maybe this should be included
through special pathway.
@bgandon bgandon force-pushed the bridged-networking branch from cf2cc49 to 53afd8b Compare October 19, 2021 14:25
@bgandon

bgandon commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

There it is, I've rebased the code and updated the docs to provide details on the network_device property.

@bgandon bgandon requested a review from rkoster October 19, 2021 14:26

@rkoster rkoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @bgandon

@rkoster rkoster merged commit 372f2df into master Oct 19, 2021
@rkoster rkoster deleted the bridged-networking branch October 19, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants