Bridged networking feature#23
Conversation
83ac2a7 to
cf2cc49
Compare
rkoster
left a comment
There was a problem hiding this comment.
When trying out these changes I'm getting:
Deploying:
Creating instance 'bosh/0':
Creating VM:
Creating vm with stemcell cid 'sc-3aec8f82-4493-4e13-63ef-6674f124c0b3':
CPI 'create_vm' method responded with error: CmdError{"type":"Bosh::Clouds::CloudError","message":"Creating VM with agent ID '{{a2de8839-3e4f-4b05-78ea-06610d254e40}}': Configuring NIC
s: Expected to find network 'en0'","ok_to_retry":false}
Had to change network_device: "en0: Wi-Fi (Wireless)" to make it work. Maybe add some docs on how to find the right device name.
| Auth: []ssh.AuthMethod{ssh.PublicKeys(keySigner)}, | ||
| User: r.opts.Username, | ||
| Auth: []ssh.AuthMethod{ssh.PublicKeys(keySigner)}, | ||
| HostKeyCallback: ssh.InsecureIgnoreHostKey(), |
There was a problem hiding this comment.
This change does not seem related to the bridged networking feature. Maybe it does fix something but it is hard to tell without context. This should probably be its own PR.
| internal_gw: 192.168.43.3 | ||
| internal_cidr: 192.168.43.0/24 | ||
| outbound_network_name: NatNetwork | ||
| network_device: en0 |
There was a problem hiding this comment.
Maybe add a note that this network_device name can be found using VBoxManage list bridgedifs . In my case on MacOS I had to use network_device: "en0: Wi-Fi (Wireless)".
| } | ||
| if testSSHRunnerHost == "" { | ||
| testSSHRunnerHost = "127.0.0.1" | ||
| } |
| It("returns proper home directory", func() { | ||
| opts := SSHRunnerOpts{ | ||
| Host: "127.0.0.1", | ||
| Host: testSSHRunnerHost, |
|
This PR contains patches from the I'll rebase on top of |
between host-only and bridged. right now, you cannot create Bridged. this is "correct" in the sense that virtualbox does not create bridged devices for you. however, maybe this should be included through special pathway.
cf2cc49 to
53afd8b
Compare
|
There it is, I've rebased the code and updated the docs to provide details on the |
This PR is extracted from #17, focusing only on the new “bridged networking” feature. The work has been rebased on top of #22.
Original PR description by @ships in #17:
Plus, we've gathered here the documentation proposed by @aussielunix in aussielunix/bosh-virtualbox-cpi-release@4bc4844.