CI: Make it clear what cleanup step is doing#376
Merged
Conversation
selzoc
commented
Oct 20, 2025
selzoc
commented
Member
- Rename teardown-infrastructure to delete-orphaned-vms - this better describes what it actually does
- Add all required params to the task YAML, and check for their presence before running commands
- Remove unused terraform inputs for network names - these names are instead generated based on the "prefix" terraform input
* Rename teardown-infrastructure to delete-orphaned-vms - this better describes what it actually does * Add all required params to the task YAML, and check for their presence before running commands * Remove unused terraform inputs for network names - these names are instead generated based on the "prefix" terraform input Co-authored-by: Aram Price <aram.price@broadcom.com>
aramprice
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.