Skip to content

Create separate setup and teardown for sole tenancy resources#367

Merged
beyhan merged 1 commit into
masterfrom
add-sole-tenancy-teardown
Aug 6, 2025
Merged

Create separate setup and teardown for sole tenancy resources#367
beyhan merged 1 commit into
masterfrom
add-sole-tenancy-teardown

Conversation

@beyhan

@beyhan beyhan commented Aug 4, 2025

Copy link
Copy Markdown
Member

The sole tenancy node is charged even when there are no running VMs inside. We should make sure that it is destroyed always. With this change the setup is created in the run-int job which needs it and makes sure to destroy the resource at the end.

@beyhan beyhan force-pushed the add-sole-tenancy-teardown branch 2 times, most recently from f4649e7 to 6f0b57f Compare August 4, 2025 13:07
The sole tenancy node is charged even when there are no running VMs
inside. We should make sure that it is destroyed always. With this
change the setup is created in the run-int job which needs it and makes
sure to destroy the resource at the end.

@ramonskie ramonskie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Aug 4, 2025
@beyhan beyhan merged commit 38785be into master Aug 6, 2025
5 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Aug 6, 2025
@beyhan beyhan deleted the add-sole-tenancy-teardown branch August 6, 2025 12:14
beyhan added a commit that referenced this pull request Aug 7, 2025
beyhan added a commit that referenced this pull request Aug 7, 2025
aramprice pushed a commit that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants