-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(vite-plugin-cloudflare): allow "invoke" other than fetchModule
#11123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite-plugin-cloudflare): allow "invoke" other than fetchModule
#11123
Conversation
🦋 Changeset detectedLatest commit: 78a5394 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
jamesopstad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and much cleaner. Thanks for the PR!
|
Congratulations @sapphi-red, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmheytdlw009wl104k2844jef This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Fixes this ecosystem-ci failure with Vite 7.2 beta:
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/18900807449/job/53947420605#step:7:695
A new invoke method was added by vitejs/vite#21029, but that was blocked by this code
workers-sdk/packages/vite-plugin-cloudflare/src/miniflare-options.ts
Lines 515 to 518 in 55657eb
This PR removes that assertion as I don't think there's a reason to block other methods. Also this PR moves the custom logic to the environment side which feels less hacky to me (I'll revert this part if preferred).
ecosystem-ci run with this branch (passed ✅): https://github.com/vitejs/vite-ecosystem-ci/actions/runs/18904416204/job/53959123391